Add support for 'scope' claim with multiple scopes #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good thanks! |
tony2001
force-pushed
the
validate_scope_claim_support_multiple_scopes
branch
from
62c8e8d
to
f72a818
Compare
|
I'm not really familiar with Python, but I think I've fixed the issues. |
|
The failing test is codespell being stupid and flagging a function name in code you have not touched, I'll fix it later. Thanks for the contribution, really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claim 'scope' is formally standardized by this RFC:
https://datatracker.ietf.org/doc/html/rfc8693#name-scope-scopes-claim
It's been in use for quite a while though and it's a part of standard token provided by Keycloak, which is a long time industry standard for access management.
Keycloak tokens may and quite often do contain multiple scopes, hence the need for this patch.