Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post about cgroup v1 support moving to maintenance mode / KEP-4569 #47069

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Blog post about cgroup v1 support moving to maintenance mode / KEP-4569 #47069

merged 1 commit into from
Aug 13, 2024

Conversation

harche
Copy link
Contributor

@harche harche commented Jul 2, 2024 •
edited
Loading

Adding a blog post about moving the cgroup v1 support to maintenance mode in kubernetes.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2024
@harche harche mentioned this pull request Jul 2, 2024
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c11da3e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b9f923d0c91f00081098af
😎 Deploy Preview https://deploy-preview-47069--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BenTheElder
Copy link
Member

BenTheElder commented Jul 3, 2024 •
edited
Loading

cc @kubernetes/contributor-comms (context: kubernetes/enhancements#4569)

@rashansmith
Copy link

Hello, I'm Rashan from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

@kaslin
Copy link
Contributor

kaslin commented Jul 17, 2024

This change just... Misspells "documentation"?

@harche
Copy link
Contributor Author

harche commented Jul 17, 2024

This change just... Misspells "documentation"?

It's a placeholder.

@chris-short
Copy link
Contributor

To confirm, you're requesting @kubernetes/contributor-comms to review the cgroups v2 blog post (once its available)?

@harche harche mentioned this pull request Jul 19, 2024
Closed
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2024
@harche harche marked this pull request as ready for review July 25, 2024 15:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
@harche harche force-pushed the cgroup_v1_blog branch 3 times, most recently from f6e68fa to 57ed44b Compare July 25, 2024 15:35
@harche
Copy link
Contributor Author

harche commented Jul 25, 2024

PTAL @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 25, 2024
@harche harche changed the title Blog post about cgroup v2 Blog post about cgroup v1 support moving to maintenance mode / KEP-4569 Jul 25, 2024
@sftim
Copy link
Contributor

sftim commented Aug 7, 2024

Let's pick a specific publication time; there are several articles due to go out on release day, and it's important that the earliest one out of the set is the release announcement.

@a-mccarthy
Copy link
Contributor

@harche based on our conversation https://github.com/kubernetes/website/pull/47281/files#r1707351032, please update the publication date to August 13th. thanks!

sftim
sftim reviewed Aug 7, 2024
View reviewed changes
content/en/blog/_posts/2024-08-15-moving-cgroup-v1-support-maintenance-mode-kubernetes-1-31.md Outdated
layout: blog
title: "Kubernetes 1.31: Moving cgroup v1 Support into Maintenance Mode"
date: 2024-08-14
slug: kubernetes-1-31-moving-cgroup-v1-support-maintenance-mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For SEO, how about:

Suggested change
slug: kubernetes-1-31-moving-cgroup-v1-support-maintenance-mode
slug: cgroup-v1-support-to-maintenance-mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other blogs I think we need to have the version mentioned somewhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope; no need.

@harche
Copy link
Contributor Author

harche commented Aug 7, 2024

@harche based on our conversation https://github.com/kubernetes/website/pull/47281/files#r1707351032, please update the publication date to August 13th. thanks!

Thanks @a-mccarthy, I just updated the date to 13th.

@harche
Copy link
Contributor Author

harche commented Aug 7, 2024

Let's pick a specific publication time; there are several articles due to go out on release day, and it's important that the earliest one out of the set is the release announcement.

How do you specify time there?

@sftim
Copy link
Contributor

sftim commented Aug 8, 2024

How do you specify time there?

Use an ISO8601 date (which includes a time); release comms will let you know what to use.

@harche
Copy link
Contributor Author

harche commented Aug 8, 2024 •
edited
Loading

How do you specify time there?

Use an ISO8601 date (which includes a time); release comms will let you know what to use.

How about 2024-08-13T00:00:00Z ?

/cc @a-mccarthy

@a-mccarthy
Copy link
Contributor

@harche based on the slack thread i had with @sftim, I think the best date for this blog to go out is August 14th. That way we dont have to worry about adding the timestamp. Do you mind update the date and file name to be August 14th?

I apologize for the back and forth on dates and information. Thank you for your patience with me as I figured out the publication schedule. Let me know if you have any questions!

cc: @rashansmith

@harche
Copy link
Contributor Author

harche commented Aug 9, 2024

@harche based on the slack thread i had with @sftim, I think the best date for this blog to go out is August 14th. That way we dont have to worry about adding the timestamp. Do you mind update the date and file name to be August 14th?

I apologize for the back and forth on dates and information. Thank you for your patience with me as I figured out the publication schedule. Let me know if you have any questions!

cc: @rashansmith

Done. Thanks!

sftim
sftim reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This is OK to publish.

/hold

🛑 Maintain the hold until Kubernetes v1.31 is released; nobody should manually merge this PR to override the hold 🛑

content/en/blog/_posts/2024-08-15-moving-cgroup-v1-support-maintenance-mode-kubernetes-1-31.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path should be content/en/blog/_posts/2024-08-14-moving-cgroup-v1-support-maintenance-mode-kubernetes-1-31.md, but we can fix that another time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

content/en/blog/_posts/2024-08-15-moving-cgroup-v1-support-maintenance-mode-kubernetes-1-31.md Outdated
Comment on lines 56 to 57
[systemd](https://github.com/systemd/systemd/issues/30852) are
transitioning towards cgroup v2, which provides several benefits over cgroup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proposing a change because you wouldn't expect a Google search for “systemd” to take you to systemd/systemd#30852

Suggested change
[systemd](https://github.com/systemd/systemd/issues/30852) are
transitioning towards cgroup v2, which provides several benefits over cgroup
[systemd](https://systemd.io/) are
[transitioning](https://github.com/systemd/systemd/issues/30852) towards cgroup v2.
Using cgroup v2 provides several benefits over cgroup

If we like it, we can make that change after this PR is approved and even after it has merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b40335fb0646fb931ca008938a855dc32e51bd9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@harche
Blog post about cgroup v1 support moving to maintenance mode / KEP-4569
c11da3e 
Signed-off-by: Harshal Patil <harpatil@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@sftim
Copy link
Contributor

sftim commented Aug 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83a6b77ac26b867d37114e90d71292396590e5ad

@johnnyboystar22 johnnyboystar22 mentioned this pull request Aug 12, 2024
Closed
@sftim
Copy link
Contributor

sftim commented Aug 13, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit db2c4c6 into kubernetes:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@kannon92 kannon92 kannon92 left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mbianchidev mbianchidev mbianchidev requested changes

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@reylejano reylejano Awaiting requested review from reylejano

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@a-mccarthy a-mccarthy Awaiting requested review from a-mccarthy

@sftim sftim Awaiting requested review from sftim

Assignees

@saschagrunert saschagrunert

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Node PR Triage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.