Prow issue: Bad invalid commit message for npm dependencies

[brendandburns]

I got this error message on:
kubernetes-client/javascript#924

[Keywords](https://help.github.com/articles/closing-issues-using-keywords) which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

But in npm libraries, the @ character is used to indicate an organization, even the default kubernetes client uses it @kubernetes/client-node

[brendandburns]

/sig testing

[brendandburns]

Also, there's no way to disable this from re-applying repeatedly very annoying.

See: kubernetes-client/javascript#926

[brendandburns]

Another PR with the same issue kubernetes-client/javascript#932

[BenTheElder]

@kubernetes/client-node could be a valid reference to a GitHub team like @kubernetes/sig-testing, which we do not want to let in a merged commit, because they will be pinged every time that commit is merged even in forks which is something you cannot disable in GitHub :/

The bot also blocks fixes #1234 because of similar behavior (closing the issue) that happens even in people's forks.

Previously: #21534, we asked GitHub if we could alter this comment

[BenTheElder]

/sig contributor-experience
(I think changing this behavior would count as a variant on #28021)

[mrbobbytables]

+1 to Ben's comment. I don't think this is something we want to change globally at least.
We have provided feedback to GitHub about this in the past, but others see it as a positive thing =/

I could potentially see a repo+user exception, but i'd defer to sig-testing and the prow folk on it.

[brendandburns]

How about a per-user exception? All of the PRs in question are sent by @dependabot which is unlikely to include any other users in it's comments.

[brendandburns]

This continues to be a problem for the Javascript client as @ syntax is quite prevalent in Javascript library names.

Even just the ability to manually disable it on a per-pr basis would be useful.

[BenTheElder]

Sorry about that, I agree we should add a user-exception for depdenabot.

There's been some churn and I'm not sure who's most active on Prow at the moment, but if current owners agree I think we can file a help-wanted to add this and someone will pick it up. cc @chaodaiG @ColeW @listx

[listx]

@cjwagner not colew

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[MadhavJivrajani]

Migrated issue: kubernetes-sigs/prow#193