-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow seems to assign Assignees who are not in OWNERS file #199
Comments
Right, Prow does that for approvers after they approve a PR. I am actually not sure why it does that :D I'm not sure how your Prow is configured, it can be configured to consider GH approves as Prow approves, which I think is the case here; your review was a GH approve. |
For completeness, here's our Prow configs for the repo. First, https://github.com/openshift/release/tree/master/ci-operator/config/opendatahub-io/notebooks (that's just CI jobs, probably not relevant). And second, here's our global prow config https://github.com/openshift/release/blob/master/core-services/prow/02_config/_config.yaml and here's the repo specific config https://github.com/openshift/release/blob/master/core-services/prow/02_config/opendatahub-io/notebooks/_prowconfig.yaml and plugin config https://github.com/openshift/release/blob/master/core-services/prow/02_config/opendatahub-io/notebooks/_pluginconfig.yaml |
It's just Kubernetes's workflow, to assign people that take over the review / approval. It gives more visibility. NOTE: anyone can |
In opendatahub-io/notebooks#587, after adding my LGTM review, openshift-ci (bot) came and "assigned adelton" as Assignee.
I'm not even listed in https://github.com/opendatahub-io/notebooks/blob/main/OWNERS so this is quite surprising and does not seem to match the referenced pull request process at https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process.
Should the prow behaviour (perhaps in https://github.com/kubernetes-sigs/prow/tree/main/pkg/plugins/assign) be modified, or should this be brought for clarification to https://github.com/kubernetes/community/?
The text was updated successfully, but these errors were encountered: