Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rag controller #622

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: add rag controller #622

merged 1 commit into from
Jan 30, 2024

Conversation

0xff-dev
Copy link
Collaborator

@0xff-dev 0xff-dev commented Jan 23, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it

feat: add rag controller

Which issue(s) this PR fixes

Fix #566

Special notes for your reviewer

The overall implementation logic is
First create the pvc and then create 4 stage jobs at a time.
The phase changes of rag are "", "init", "download", "generate", "judge", "upload", "complete" at a time. You can tell if a phase is complete by type=complete and status=true in condition.

The rag will be suspend, the current stage of the job will be stopped, has been completed will not be processed. rag recovery, the current stage of the job will be re-created to continue execution of the pod, so the need for each stage to ensure that they can support the recovery of the suspend operation, to avoid suspend, after the recovery, the job can not be executed normally.

If the data source of the rag, the associated application, the judge llm, or the storage changes, it will go back to the first step to re-execute.

@0xff-dev 0xff-dev force-pushed the eva-controller branch 2 times, most recently from c60956e to 5992b46 Compare January 24, 2024 01:10
@0xff-dev 0xff-dev marked this pull request as draft January 24, 2024 03:20
@0xff-dev 0xff-dev force-pushed the eva-controller branch 3 times, most recently from 5739a2e to bbdeec5 Compare January 24, 2024 15:52
@0xff-dev 0xff-dev marked this pull request as ready for review January 24, 2024 15:52
@0xff-dev 0xff-dev force-pushed the eva-controller branch 3 times, most recently from 5f3947c to 0d972d1 Compare January 25, 2024 01:34
pkg/evaluation/jobs.go Outdated Show resolved Hide resolved
@0xff-dev 0xff-dev force-pushed the eva-controller branch 6 times, most recently from ef73486 to 367c772 Compare January 29, 2024 02:15
Copy link
Collaborator

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you have a successful job run before making this pr merged.

@bjwswang bjwswang changed the title feat: add rag controller [WIP]feat: add rag controller Jan 29, 2024
@0xff-dev 0xff-dev force-pushed the eva-controller branch 2 times, most recently from 2b2cacc to 44998e3 Compare January 29, 2024 15:36
@bjwswang bjwswang merged commit 71b8f02 into kubeagi:main Jan 30, 2024
9 checks passed
@0xff-dev 0xff-dev deleted the eva-controller branch January 30, 2024 02:22
@0xff-dev 0xff-dev changed the title [WIP]feat: add rag controller feat: add rag controller Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement evaluations.rag controller
2 participants