chore: run pylint locally and fix lint issues #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjwswang
force-pushed
the
main
branch
3 times, most recently
from
bbc245b
to
3246260
Compare
|
@wangxinbiao There are still lots of warnings,erors in pylint. Please fix that later. |
bjwswang
commented
Jan 22, 2024
| @@ -300,6 +300,18 @@ prepare-push: manifests generate fmt vet gql-gen | |||
| @go install github.com/swaggo/swag/cmd/swag@latest | |||
| @swag init -o apiserver/docs . | |||
|
|
|||
| PYTHON_INDEX_URL ?=https://pypi.mirrors.ustc.edu.cn/simple/ | |||
| .PHONY: prepare-push-pypi | |||
| prepare-push-pypi: | |||
There was a problem hiding this comment.
@wangxinbiao @ggservice007 we should do this format,lint before make a commit
bjwswang
force-pushed
the
main
branch
2 times, most recently
from
8bae9aa
to
3888aac
Compare
bjwswang
requested review from
ggservice007 and
wangxinbiao
and removed request for
Abirdcfly and
0xff-dev
Signed-off-by: bjwswang <bjwswang@gmail.com>
bjwswang
changed the title
wangxinbiao
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #591
Special notes for your reviewer