feat: add CRD Application #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
force-pushed
the
app
branch
12 times, most recently
from
484e6ff
to
e7c4b35
Compare
Abirdcfly
force-pushed
the
app
branch
18 times, most recently
from
7bd7d80
to
290ce34
Compare
Abirdcfly
force-pushed
the
app
branch
5 times, most recently
from
19b4dcc
to
c823359
Compare
0xff-dev
approved these changes
Nov 27, 2023
bjwswang
reviewed
Nov 29, 2023
bjwswang
reviewed
Nov 29, 2023
bjwswang
reviewed
Nov 29, 2023
bjwswang
reviewed
Nov 29, 2023
bjwswang
reviewed
Nov 29, 2023
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
bjwswang
reviewed
Nov 29, 2023
| return app, ctrl.Result{}, nil | ||
| } | ||
| } | ||
| toOutputNodeNext = len(node.NextNodeName) |
There was a problem hiding this comment.
maybe combine this two for _,node := range app.Spec.Nodes together ?
bjwswang
reviewed
Nov 29, 2023
| // 7. should not have cycle TODO | ||
| // 8. nodeName should be unique | ||
| func (r *ApplicationReconciler) validateNodes(ctx context.Context, log logr.Logger, app *arcadiav1alpha1.Application) (*arcadiav1alpha1.Application, ctrl.Result, error) { | ||
| var input, output int |
There was a problem hiding this comment.
This is a strict rule for app developers. We need a document later.
bjwswang
reviewed
Nov 29, 2023
| limitations under the License. | ||
| */ | ||
|
|
||
| package zhipuai |
There was a problem hiding this comment.
Greate! #79 This issue can be closed as well. Right ? @Abirdcfly
bjwswang
reviewed
Nov 29, 2023
bjwswang
reviewed
Nov 29, 2023
| "github.com/kubeagi/arcadia/pkg/llms/zhipuai" | ||
| ) | ||
|
|
||
| var _ llms.LLM = (*ZhipuLLM)(nil) |
There was a problem hiding this comment.
Since our worker provides openai-compatible apis , we need to support openai llm ASAP
bjwswang
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
@Abirdcfly Nice job!
We need to support
knowledgebaseas a nodeopenaias a llm
Then we shall have a complete llmops! ⭐
|
track remaining issue using #308 |
nkwangleiGIT
added a commit
to nkwangleiGIT/arcadia
that referenced
this pull request
Dec 1, 2023
feat: add CRD Application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #132
Special notes for your reviewer
https://shimo.im/docs/vVqRM4yWXWUXlj3y
source: https://github.com/Abirdcfly/llm-examples/blob/main/chatbot.py
online url: http://172.22.96.167:8502/