Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Run analysis and dependency commands in the same container / pod #172

Closed
pranavgaikwad opened this issue Mar 8, 2024 · 2 comments
Closed

[Bug] Run analysis and dependency commands in the same container / pod #172

pranavgaikwad opened this issue Mar 8, 2024 · 2 comments
Assignees
@shawn-hurley
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pranavgaikwad
Copy link
Contributor

There are several performance advantages to doing this:

  1. we currently share m2 directory between containers to speed things up, but that doesn't work on mac
  2. when we decompile a JAR, we end up decompiling twice because analyze command updates the base path (to run things faster), but dependency command does not
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 8, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 8, 2024
@pranavgaikwad pranavgaikwad mentioned this issue Mar 8, 2024
Closed
1 task
@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 11, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 11, 2024
@shawn-hurley
Copy link
Contributor

This was completed in #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawn-hurley shawn-hurley

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawn-hurley @pranavgaikwad