Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https to reach kalliope API #27

Open
JulienSambre opened this issue Jul 24, 2019 · 6 comments · May be fixed by #28
Open

Use https to reach kalliope API #27

JulienSambre opened this issue Jul 24, 2019 · 6 comments · May be fixed by #28

Comments

@JulienSambre
Copy link

Hi!

I'm currently using the app for sending orders to kalliope.

There are some anoying bugs (like text of orders appearing in chat text box, etc), but i can deal with them, and all in all it works.

However, i can't reach the Kalliope API on https and i had to open port 80 on my proxy and let the app communicate on http, which is highly unsecure.

Am I missing something and if not would it be possible de call an https endpoint?

Thanks!

@Sispheor
Copy link
Member

It's not the job of kalliope to implement the ssl termination. Add a reverse proxy in front for that.

@JulienSambre
Copy link
Author

JulienSambre commented Jul 24, 2019

I have done that, but if I put in URL field one of the following, none of them works :

subdomain.domain.name:443
https://subdomain.domain.name:443
https://subdomain.domain.name

I have the error : "Connection failed : Response with status: 0 for URL: null". I have no problem if I put : "subdomain.domain.name:80" and I have the same error if I put "http://subdomain.domain.name:80" or "http://subdomain.domain.name"

My domain name is recognized in public DNS and works for all of my other subdomain and I have valid server certificate. I have a HAProxy which do the SSL termination and redirect to Kalliope API in http.

@Sispheor
Copy link
Member

The idea is to perform the SSL termination only to the frontend. Then a normal http call betwwen the front and the kalliope rest server.

@JulienSambre
Copy link
Author

I agree and that's what I did. I do that way for alot of my applications (like Gotify for receiving Kalliope notifications on several phones). Protocol change from https to http after proxy is something that I manage everyday at work. I put a diagram of what I did to be sure :).

Kalliope Proxy

Therefore, I don't manage to make it work for https and the error part "for URL: null" made me ask myself what is wrong. Long story short, how the app know when he must do a https call (between the app and the front proxy)?

For better understanding, could you tell me what kind of URL is supported? Because from what I tested, only [domain/ip]:[port] works and so, how does the app know when to do a https call?

@Sispheor
Copy link
Member

Please go on Gitter when you have time to discuss this

@Sispheor Sispheor reopened this Jul 24, 2019
@Sispheor
Copy link
Member

It's a bug. We've hard coded the protocol.
@LaMonF see here :)

@redSpoutnik redSpoutnik linked a pull request Oct 20, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants