Export contains now deleted rows, is this intentional?

[aligator]

Hi,

I got a request of a user:
Before 2023-11, the export did not contain deleted values.
Now it does.

This confused a user of mine and I investigated it. I noticed that the export now overrides the deleted check with null.
https://github.com/julien-nc/cospend-nc/blame/a7531402044794b5225133467f126587708aab9f/lib/Service/ProjectService.php#L4328
Instead it now contains the deleted column.

I would like to know if this is intentional (I think so), or not.

If it is intentional, maybe a configurable flag to toggle this behavior would be nice. (However for my user it is not mandatory, since we know now that it changed the behavior and can live with it, we were just a bit confused...)

[aligator]

Ok found #289 (comment) - so it is intentional.
However as it seems to confuse not just me:
maybe this is a valid feature request to allow to toggle if the export should contain the trash.

[julien-nc]

Hi. This is intentional. The main purpose of exporting a project IMO is to be able to import it back. So all the data is exported, even the content of the trash.

This behaviour changed when the "trash" feature appeared. Before that, deleted bills were really deleted. So in a sense, the logic didn't change: Cospend exports all the project data.

Any reason why exported files should not contain the trash?
People can filter them out when reading/parsing the exported file on their own.
I want to avoid having one more setting for something that seems good as it is now. I hope you understand.

[aligator]

I think the use case of my user is a very specific one as she has a workflow where she exports the project every month, copies the data into her own excel with extra calculations and then deletes everything in the project. As she only looked at the first row and saw that it still contains data from 2023 she was confused.

However as this is a special use case of one user, and it is clarified now, it should be ok now.
Not sure how many other users use the export in a similar way.