Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mail.Address instead of plain strings #129

Open
ivanjaros opened this issue Nov 14, 2020 · 3 comments
Open

Use mail.Address instead of plain strings #129

ivanjaros opened this issue Nov 14, 2020 · 3 comments

Comments

@ivanjaros
Copy link

ivanjaros commented Nov 14, 2020

Use mail.Address.String() for headers, where full format works, and use mail.Address.Address for smtp's mail and rcpt methods to make it work with the smtp protocol.

@bosim
Copy link
Contributor

bosim commented Dec 29, 2020

You mean what is done in #132 ?

@ivanjaros
Copy link
Author

no. i mean the mail address object should be used in place of string arguments, ie. every occurrence of email should be an object.

@bosim
Copy link
Contributor

bosim commented Jan 2, 2021

Make sense, however it will break existing functionality, and will not make a big difference, since the library anyway use Address.String() for serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants