Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SquishIt can't minify e5-shim #313

Open
drewfreyling opened this issue Jun 11, 2015 · 4 comments
Open

SquishIt can't minify e5-shim #313

drewfreyling opened this issue Jun 11, 2015 · 4 comments

Comments

@drewfreyling
Copy link

Getting a javascript error: Unexpected token ,

Steps to repo:

@(Bundle.JavaScript()
      .Add("~/Scripts/jquery-1.10.2.min.js")
      .Add("~/Scripts/es5-shim.min.js").ForceRelease().MvcRender("~/Scripts/main.js"))
  • Run it and you should get the error
@AlexCuse
Copy link
Collaborator

This is unlikely to be a SquishIt problem, try using the YUI minifier.

@AlexCuse
Copy link
Collaborator

I usually configure this globally in Application_Start

            Bundle.ConfigureDefaults()
                  .UseYuiForCssMinification()
                  .UseYuiForJsMinification()

@drewfreyling
Copy link
Author

@AlexCuse I think it is a SquishIt issue because the version of ajaxmin is capped (AjaxMin (≥ 4.48.4489.28432 && ≤ 4.97.4951.28483) - so out of the box the maximum version of the minifier that is specified does not work.

@AlexCuse
Copy link
Collaborator

That is because there are breaking changes in ajaxmin past that version. I plan to update in v1.0. f you want to use a newer version in the meantime you can implement your own minifiers but I would suggest using YUI (this is going to be the default in 1.0)

@AlexCuse AlexCuse mentioned this issue Jun 22, 2015
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants