Low disk space check not working properly

[winterqt]

rtorrent/src/command_events.cc

Lines 242 to 245 in b7ccf41

	downloadList->close(*itr);
	(*itr)->set_hash_failed(true);
	(*itr)->set_message(std::string("Low diskspace."));

On v0.9.8-r16, I have not seen the "Low diskspace" error message more often than seeing it. Torrents stop successfully, and "Closed torrents due to low diskspace" is logged, it's just that I don't see the "Low diskspace" error message on the torrents. I do believe that I have seen it before, though.

[jesec]

The error messages are cleared after a while. There is no change in related code, so I don't think we have any issue there.

By the way, maybe you applied the optimization I mentioned in Discord, and disabled the routine low disk space check (it is not useful when rTorrent pre-allocate space for the whole torrent).

[winterqt]

The error messages are cleared after a while.

Where's that done? Ah, I see.

The torrents are stopped, though, so why would that routine run? rTorrent shouldn't be announcing stopped torrents... am I looking at the wrong routine?

By the way, maybe you applied the optimization I mentioned in Discord, and disabled the routine low disk space check (it is not useful when rTorrent pre-allocate space for the whole torrent).

I have not, solely because I haven't done enough research as to how it'll behave on ZFS. (My initial research showed that OpenZFS would only make a best case effort to assure that the size requested was available, so that's why I have preallocation disabled as a whole.)

[winterqt]

It seems that the error message is cleared after ~1 second, which I can see by polling Flood's torrent list API every second. I see that torrents are errored for one request, and then the error state is cleared on the next request. 🤔

In other cases, I don't see the error state at all, it goes straight to stopped + inactive. Restarting rTorrent properly sets the status for these torrents, though.