Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation includes mention of deleted token salting #323

Closed
dgerlanc opened this issue Dec 13, 2023 · 3 comments
Closed

Documentation includes mention of deleted token salting #323

dgerlanc opened this issue Dec 13, 2023 · 3 comments

Comments

@dgerlanc
Copy link

dgerlanc commented Dec 13, 2023

The documentation includes a setting for SALT_LENGTH even though salting was removed long ago.

Would be great to remove this reference as it suggests that salting of tokens is still used!

I searched the head of the develop branch and could not find a mention of this setting except in the changelog and migrations so I'm not sure why it's showing up in the docs!

See https://jazzband.github.io/django-rest-knox/settings/.

image

@dgerlanc dgerlanc changed the title Documentation includes mention of deleted feature Documentation includes mention of deleted token salting Dec 13, 2023
@johnraz
Copy link
Collaborator

johnraz commented May 2, 2024

This most likely comes from the fact that the gh-pages branch is outdated ... https://github.com/jazzband/django-rest-knox/blob/gh-pages/settings/index.html.

I will mention this in #304

@giovannicimolin
Copy link
Contributor

@johnraz @dgerlanc We now have a Ci job that automatically deploys the latest documentation to GH-pages.

#343

@johnraz
Copy link
Collaborator

johnraz commented May 3, 2024

@giovannicimolin wonderful doc is up to date now! Closing this one

@johnraz johnraz closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants