Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints and the py.typed stub #551

Closed
wants to merge 1 commit into from

Conversation

fabiommendes
Copy link

Problem

Model utils does not include type hints and py.typed. This prevents tools such as mypy to work properly with it.

Solution

Add model_utils/py.typed and a few typing hints.

Commandments

  • Write PEP8 compliant code.
  • [_] Cover it with tests.
  • [_] Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • [_] Update documentation (if relevant).

@foarsitter
Copy link
Contributor

Typing will be covered in #558 so I have to close this PR since it is incomplete.

@foarsitter
Copy link
Contributor

See #603 for the ongoing progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants