Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner interface #10

Open
jakehschwartz opened this issue Apr 25, 2017 · 4 comments
Open

Cleaner interface #10

jakehschwartz opened this issue Apr 25, 2017 · 4 comments
Assignees
@jakehschwartz
Labels
enhancement hacktoberfest

Comments

@jakehschwartz
Copy link
Owner

Clean up the interface a bit:

  • Change SwaggerController to DocsController
  • Move controllers to controller package
  • More
@jakehschwartz jakehschwartz self-assigned this Apr 25, 2017
@jakehschwartz jakehschwartz reopened this Apr 25, 2017
@jakehschwartz
Copy link
Owner Author

jakehschwartz commented Apr 25, 2017 •
edited
Loading

I don't like the fact that there are 2 controllers to import, will merge WebjarsController into DocsController

@jakehschwartz jakehschwartz reopened this Apr 25, 2017
@jakehschwartz
Copy link
Owner Author

Nevermind, I'll leave this for now

@jakehschwartz
Copy link
Owner Author

jakehschwartz commented Apr 26, 2017 •
edited
Loading

Changed my mind again. The main bonuses are ease of use (only having 1 controller) and more Finatra like (having Swagger be managed through DI)

@jakehschwartz jakehschwartz reopened this Apr 26, 2017
@jakehschwartz
Copy link
Owner Author

This is cleaner than it was, but it would be nice not have to inject the Swagger object in all the controllers just so it can be assigned to an implicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakehschwartz jakehschwartz

Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakehschwartz