Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit 200 test for dnslink-gateway #212

Open
3 tasks
lidel opened this issue Jun 8, 2024 · 0 comments
Open
3 tasks

Add explicit 200 test for dnslink-gateway #212

lidel opened this issue Jun 8, 2024 · 0 comments
Labels
dif/medium Prior experience is likely helpful good first issue Good for newcomers help wanted Extra attention is needed P2 Medium: Good to have, but can wait until someone steps up test:coverage Improves the spec covered by this test suite

Comments

@lidel
Copy link
Member

lidel commented Jun 8, 2024

While refactoring #211 I notices we test _redirects on DNSLink gateway, but not really have a basic test for reading bytes when the Host points at DNSLink domain.

  • confirm we relaly dont have it
  • add it, or move to explicit file
  • add proxy tests, similar to ones in tests/subdomain_gateway_proxy_test.go
@lidel lidel added the test:coverage Improves the spec covered by this test suite label Jun 8, 2024
@lidel lidel added help wanted Extra attention is needed good first issue Good for newcomers P2 Medium: Good to have, but can wait until someone steps up dif/medium Prior experience is likely helpful labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/medium Prior experience is likely helpful good first issue Good for newcomers help wanted Extra attention is needed P2 Medium: Good to have, but can wait until someone steps up test:coverage Improves the spec covered by this test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel