Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing check for 32bit routeserver asn? #870

Closed
jbemmel opened this issue Aug 3, 2023 · 1 comment
Closed

Missing check for 32bit routeserver asn? #870

jbemmel opened this issue Aug 3, 2023 · 1 comment

Comments

@jbemmel
Copy link

jbemmel commented Aug 3, 2023

Just wondering - I noticed

IXP-Manager/resources/views/api/v4/router/server/bird/community-filter.foil.php

Line 55 in b5d596c

if peerasn > 65535 then

while

IXP-Manager/resources/views/api/v4/router/server/bird2/community-filter.foil.php

Line 73 in b5d596c

if routeserverasn > 65535 || peerasn > 65535 then
uses

 # it's unwise to conduct a 32-bit check on a 16-bit value
    if routeserverasn > 65535 || peerasn > 65535 then
            return true;

Shouldn't the first one do the same?
@jbemmel
Copy link
Author

jbemmel commented Aug 3, 2023

Actually, #842 so I guess this is a moot point

@barryo barryo closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barryo @jbemmel