Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying multiple files as arguments #96

Open
foens opened this issue Nov 28, 2022 · 1 comment
Open

Allow specifying multiple files as arguments #96

foens opened this issue Nov 28, 2022 · 1 comment

Comments

@foens
Copy link

foens commented Nov 28, 2022

Hi there.

We have current tooling that can detect which files were changed in a large repository. We currently pass all the paths to these files to gofmt for formatting, but would like to use this tool instead.

However, since we are only able to pass a single file at a time, there is a performance overhead, as we need to call the binary many times.

If we pass a full folder, the tool will use wasted cycles running on code that was not changed, which will not work on our large codebase.

Is it possible that you could support formatting any number of files given as arguments?

@zakir-code
Copy link

find . -name '*.go' -type f -not -path './build*' -exec goimports-reviser -use-cache -rm-unused {} \;

This is how I use it, I hope it can help you.

n-oden added a commit to odenio/goimports-reviser that referenced this issue Jul 5, 2024
This addresses incu6us#96

- iterate over the list of remaining arguments treating
  each as an origin path

- fully remove support for the -filePath option

- defer printing deprecation warnings until after all paths
  are processed

- print deprecation warnings to stderr, not stdout
n-oden added a commit to odenio/goimports-reviser that referenced this issue Jul 5, 2024
This addresses incu6us#96

- iterate over the list of remaining arguments treating
  each as an origin path

- fully remove support for the -filePath option

- defer printing deprecation warnings until after all paths
  are processed

- print deprecation warnings to stderr, not stdout
n-oden added a commit to odenio/goimports-reviser that referenced this issue Jul 8, 2024
This addresses incu6us#96

- iterate over the list of remaining arguments treating
  each as an origin path

- fully remove support for the -filePath option

- defer printing deprecation warnings until after all paths
  are processed

- print deprecation warnings to stderr, not stdout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants