diff --git a/archive.json b/archive.json index ca2898ef..3a2f8a40 100644 --- a/archive.json +++ b/archive.json @@ -1,6 +1,6 @@ { "magic": "E!vIA5L86J2I", - "timestamp": "2023-10-07T19:32:42.947350+00:00", + "timestamp": "2023-10-09T19:14:52.121151+00:00", "repo": "ietf-rats-wg/eat", "labels": [ { @@ -22451,24 +22451,26 @@ "id": "PR_kwDOCEWCXc5a7dIX", "title": "Improve JSON nonce min and max size", "url": "https://github.com/ietf-rats-wg/eat/pull/421", - "state": "OPEN", + "state": "MERGED", "author": "laurencelundblade", "authorAssociation": "COLLABORATOR", "assignees": [], "labels": [], "body": "A private comment from Thomas (thx) caused me to think through the size of nonces for JSON-encoded tokens again. The new text is more obvious and gives more flexibility.\r\n\r\nThe main point of restricting a size range of the nonce is to help developers. The max size makes it clear what size buffer they need to allocate. The min size makes sure they are at least trying to get enough entropy.", "createdAt": "2023-09-21T20:35:10Z", - "updatedAt": "2023-10-05T19:14:48Z", + "updatedAt": "2023-10-09T19:13:37Z", "baseRepository": "ietf-rats-wg/eat", "baseRefName": "master", "baseRefOid": "caa9fb8378885f4baa6308c9e20741fbd17ab2f7", "headRepository": "ietf-rats-wg/eat", "headRefName": "nonce-size", "headRefOid": "819259ab9775c3aa796d0e8ec3ce674fb550f33c", - "closedAt": null, - "mergedAt": null, - "mergedBy": null, - "mergeCommit": null, + "closedAt": "2023-10-09T19:13:33Z", + "mergedAt": "2023-10-09T19:13:33Z", + "mergedBy": "laurencelundblade", + "mergeCommit": { + "oid": "4b6206204df9444892b3c0e1aa4eea6a9924d99f" + }, "comments": [ { "author": "carl-wallace", @@ -22920,19 +22922,33 @@ "labels": [], "body": "", "createdAt": "2023-10-07T19:32:29Z", - "updatedAt": "2023-10-07T19:32:29Z", + "updatedAt": "2023-10-09T13:14:08Z", "baseRepository": "ietf-rats-wg/eat", "baseRefName": "master", "baseRefOid": "fd64a1bd9749cf49082091de38895f48a6d41c95", "headRepository": "ietf-rats-wg/eat", "headRefName": "mac-ueid", - "headRefOid": "2bd68b2a3573c0d5d56b75b7099386d2bdb12698", + "headRefOid": "d2e058e540964e9618e7bb1c63fc06cce672c092", "closedAt": null, "mergedAt": null, "mergedBy": null, "mergeCommit": null, "comments": [], - "reviews": [] + "reviews": [ + { + "id": "PRR_kwDOCEWCXc5jNSW6", + "commit": { + "abbreviatedOid": "d2e058e" + }, + "author": "carl-wallace", + "authorAssociation": "COLLABORATOR", + "state": "CHANGES_REQUESTED", + "body": "The \"some devices\" part does not seem right. Suggest:\r\n\r\n```\r\nMAC addreses that not permanent in accordance with requirement in this document MUST not be used for the UEID\r\n```", + "createdAt": "2023-10-09T13:14:08Z", + "updatedAt": "2023-10-09T13:14:08Z", + "comments": [] + } + ] } ] } \ No newline at end of file