ord_info #31
Merged
ord_info #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arturstrag could you install linter in your environment (flake8 preferred): https://code.visualstudio.com/docs/python/linting and make flake8 tests green (approved)? Then I will check the code. Just follow linter's instructions and commit changes into the branch which you use |
|
@Arturstrag Thank you for your input! I've made a minor refactoring, and the code is ready for another round of checks. @Reckony could you make a review? I've accepted this PR, but we should stick to the flow where multiple people check a code. |
SimonMolinsky
approved these changes
Sep 19, 2023
Reckony
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.