Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #28 implementation #30

Merged
merged 10 commits into from
Sep 10, 2023
Merged

issue #28 implementation #30

merged 10 commits into from
Sep 10, 2023

Conversation

Reckony
Copy link
Collaborator

@Reckony Reckony commented Aug 7, 2023

No description provided.

@Reckony
Copy link
Collaborator Author

Reckony commented Aug 7, 2023

I was not sure if we want to pass all parameters that are optional in describe() method, so left only percentiles - seems most relevant, because list will contain only numerical data, so no need to include/exclude any type.
Description of the issue was very brief, so it is minimum implementation.

@Reckony Reckony mentioned this pull request Aug 7, 2023
@SimonMolinsky
Copy link
Member

SimonMolinsky commented Aug 9, 2023

Hi @Reckony

I've checked the changes, and thank you for the great tests for so simple function! Everything works as expected, but when I looked into the output statistics I saw that the column name is 0. Could you change it to summary? (It wasn't stated in the issue, but I think it could be nice to have this name instead of neutral zero :) )

@Reckony
Copy link
Collaborator Author

Reckony commented Sep 5, 2023

Requested changes done

@SimonMolinsky SimonMolinsky merged commit 02a6042 into main Sep 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants