Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration without /admin #11

Open
juriansluiman opened this issue Jan 6, 2022 · 0 comments
Open

Integration without /admin #11

juriansluiman opened this issue Jan 6, 2022 · 0 comments

Comments

@juriansluiman
Copy link

juriansluiman commented Jan 6, 2022 •
edited
Loading

After digging through the source I noticed the the /admin is hard coded in the URL string.

I put my pi-hole behind Traefik with a piece of middleware so my /admin is removed from the URL. This way, I access the dashboard via https://dns1.mydomain/ and https://dns2.mydomain/. I tried integrating both pi-hole's into HA and stumbled upon this issue.

Before trying something (I know some python to make a PR but have no idea how to patch a module which somehow lives inside HA), I open this issue just to check if this will be an acceptable solution. A code example is put here:

c1dbfa1...juriansluiman:patch-1
juriansluiman added a commit to juriansluiman/python-hole that referenced this issue Jan 6, 2022
@juriansluiman
Allow instance with empty location
f170aad 
Example patch to accompany home-assistant-ecosystem#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juriansluiman