Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LumenAI Views in Sidebar #610

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

LumenAI Views in Sidebar #610

wants to merge 3 commits into from

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jul 18, 2024

Closes #606

artifacts.mp4

This makes expensive views like plots and tables, pop up one at a time, on the sidebar instead of showing up in the chat feed, to prevent it from becoming laggy.

Logically, these views would make more sense to pop up on the right side, but templates only support sidebar on the left. Perhaps in the future, there can be a right_sidebar.

@ahuang11 ahuang11 requested a review from philippjfr July 18, 2024 23:56
lumen/ai/agents.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Appreciate the initiative on this, definitely looks better than what I had originally thought it would look like. That said I think we need to carefully think about UI/UX in general and work through some proposals. Separately is performance really still such a major issue? Seemed a lot better last I tried but I guess if chat is long enough it will always be an issue.

@ahuang11
Copy link
Contributor Author

That said I think we need to carefully think about UI/UX in general and work through some proposals.

I think if we can implement a right-sidebar, that'd be great. Another thought is pushing the view to a modal if we don't want to force user to use a template.

One unaddressed issue with the current PR is exporting it is broken at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LumenAI should output plots/tables to the sidebar
2 participants