WIP bug related to the firebase storage fix #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tedspare/mu-map/ASS6uEktGYfsTi6Axs7gQ7ubwgS1 [Deployment for 66c8132 failed] |
|
The source of the Vercel error:
|
|
@SiboYang would you be open to revisiting this a year later? 😂 Your solution is clean - it seems like |
sure! will do that next week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we make get request to the mural in the firebase storage, we need to include a token.. I think that's the reason of the 404 error when getting mural images. reference
After fixing this, currently trying to find out why the uploaded images is [undefined], even though I can see the source gets console logged....
Test Plan
How did you test your changes?
Related Issues
#167
(I think -@tedspare)