Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding under main div to ensure space for footer #89

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

philmcmahon
Copy link
Contributor

What does this change?

This PR resolves a bug where on certain phone screens you can't click the submit button because the 'about this tool' footer thing gets in the way. As the footer is absolutely positioned it will go on top of the submit button. We resolve this by adding some padding 🥳

How to test

Use a 'short and wide' phone layout to reproduce the bug

@philmcmahon philmcmahon requested a review from a team as a code owner June 26, 2024 13:17
Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🥳

@philmcmahon philmcmahon merged commit 21a7133 into main Jun 26, 2024
3 checks passed
@philmcmahon philmcmahon deleted the ensure-space-fotter branch June 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants