check instance lifecycle before starting the work #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>
Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>
philmcmahon
reviewed
Apr 3, 2024
| (i) => i.InstanceId === instanceId, | ||
| )?.LifecycleState; | ||
| if (lifecycleState === undefined) | ||
| throw new Error('Could not find instance lifecycle state!'); |
There was a problem hiding this comment.
maybe include curly braces https://softwareengineering.stackexchange.com/questions/16528/single-statement-if-block-braces-or-no
There was a problem hiding this comment.
agreed - this felt wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paired with @zekehuntergreen
What does this change?
We found several instances that had been launched several days previously without being scaled in. This delayed subsequent transcription jobs because the ASG capacity manager wouldn't update desired capacity.
The related logs for these instances were showing that the service had gone into failed state because of exception when trying to update scaling protection.
AutoScalingServiceException [ValidationError]: The instance <instanse-id> is not in InService or EnteringStandby or Standby.Looking at AWS documentation, the instance can only go into
Standby&EnteringStandbystates through user interaction. So most probably, the state of the instance in our case wasPending.In this change
InService, it won't continue the work, but rather waits for 30 seconds.How to test