Enforce selection of media file language #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marjan Kalanaki <15894063+marjisound@users.noreply.github.com>
Co-Authored-By: Marjan Kalanaki <15894063+marjisound@users.noreply.github.com>
Co-Authored-By: Marjan Kalanaki <15894063+marjisound@users.noreply.github.com> Co-Authored-By: Sam Cutler <5560113+itsibitzi@users.noreply.github.com> Co-Authored-By: Luke Hoyland <luke.hoyland@theguardian.com>
this isn't true - when we pass language 'auto', the model detects the language that most of the audio is in, then only transcribes audio in that language, ignoring the rest
philmcmahon
reviewed
Mar 21, 2024
| // being submitted without any files selected. Need to confirm this in | ||
| // order to narrow the type of files | ||
| if (files === null || files.length === 0) { | ||
| console.error('form submitted without any files'); |
There was a problem hiding this comment.
since we don't have anything shipping client side logs anywhere, I'm not sure it's worth logging here
philmcmahon
approved these changes
Mar 21, 2024
Co-Authored-By: Sam Cutler <5560113+itsibitzi@users.noreply.github.com> Co-Authored-By: Luke Hoyland <luke.hoyland@theguardian.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Dropdownelement to a reactSelectelement. The former didn't work on some mobile devices. When it was selected, the dropdown opened upward (regardless ofplacementproperty) and couldn't be navigated by swiping or scrolling.useStatehookBefore
auto-detect language is the default, language picker doesn't work
language.picker.bug.mov
after
no default language, language picker does work
language.picker.fixed.mov
How to test
How can we measure success?