trim trailing newline from instance id

Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>
guardian · Apr 3, 2024 · 2eb902a · 2eb902a
1 parent 72a46e9
commit 2eb902a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/worker/src/asg.ts b/packages/worker/src/asg.ts
@@ -16,7 +16,7 @@ export const updateScaleInProtection = async (
 			logger.info(`instanceId retrieved from worker instance: ${instanceId}`);
 
 			const input = {
-				InstanceIds: [instanceId.trim()],
+				InstanceIds: [instanceId],
 				AutoScalingGroupName: `transcription-service-workers-${stage}`,
 				ProtectedFromScaleIn: value,
 			};
@@ -40,7 +40,7 @@ export const getInstanceLifecycleState = async (
 	try {
 		if (stage !== 'DEV') {
 			const input = {
-				InstanceIds: [instanceId.trim()],
+				InstanceIds: [instanceId],
 			};
 			const command = new DescribeAutoScalingInstancesCommand(input);
 			const result = await autoScalingClient.send(command);

diff --git a/packages/worker/src/index.ts b/packages/worker/src/index.ts
@@ -49,7 +49,10 @@ export const getCurrentReceiptHandle = () => CURRENT_MESSAGE_RECEIPT_HANDLE;
 
 const main = async () => {
 	const config = await getConfig();
-	const instanceId = readFile('/var/lib/cloud/data/instance-id');
+	const instanceId =
+		config.app.stage === 'DEV'
+			? ''
+			: readFile('/var/lib/cloud/data/instance-id').trim();
 
 	const metrics = new MetricsService(
 		config.app.stage,