Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log if repo is private #33

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

marsavar
Copy link
Contributor

@marsavar marsavar commented Jul 4, 2024

What does this change?

The action is outputting detailed logs, which is not great if a repository is private.
For now, I think it's easier to simply not print logs if a repository is private, unless there's a compelling strategy to adopt a different strategy (such as making the prnouncer-config repo itself private)

I've also got rid of the getset library which inflates the binary size a little bit because it produces generated code for the derived traits where a pub modifier on the structs is enough.

@marsavar marsavar merged commit a53095a into main Jul 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants