Improve CI #28
Merged
Improve CI #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
approved these changes
Jul 2, 2024
| with: | ||
| rust-version: 1.58 |
There was a problem hiding this comment.
How does it know what version of rust to use without this?
There was a problem hiding this comment.
It will use what's available on the runner, which is currently Rust 1.79
It's fine if the runner bumps versions, Rust is backward compatible by design so it won't break. The toml file in this project also specifies the Rust edition (2021) so the compiler will respect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the toolchain installation step since Rust now is available on runner images.
Also splits CI into 4 jobs:
cargo checkwhich makes sure the code compiles without errors)I've also fixed all the errors flagged by the linting tool.
How to test
I've made CI fail on purpose, it worked: