Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitap driver #1611

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Merge branch 'grumpycoders:main' into psyqo_tap_driver

e3c2d48
Select commit
Loading
Failed to load commit list.
Open

Multitap driver #1611

Merge branch 'grumpycoders:main' into psyqo_tap_driver
e3c2d48
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 5, 2024 in 29s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 8.79

  • Declining Code Health: 6 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method advancedpad.cpp: psyqo::AdvancedPad::readPad
  • Bumpy Road Ahead advancedpad.cpp: psyqo::AdvancedPad::readPad
  • Overall Code Complexity advancedpad.cpp
  • Deep, Nested Complexity advancedpad.cpp: psyqo::AdvancedPad::readPad
  • Complex Method advancedpad.cpp: psyqo::AdvancedPad::outputMultitap
  • Complex Method advancedpad.cpp: psyqo::AdvancedPad::processChanges

Annotations

Check warning on line 276 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

psyqo::AdvancedPad::readPad has a cyclomatic complexity of 28, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 115 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

psyqo::AdvancedPad::outputMultitap has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 140 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

psyqo::AdvancedPad::processChanges has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 276 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

psyqo::AdvancedPad::readPad has 5 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 7.88 across 8 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 276 in src/mips/psyqo/src/advancedpad.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

psyqo::AdvancedPad::readPad has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.