Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CD-Rom code. #1129

Open
wants to merge 227 commits into
base: main
Choose a base branch
from
Open

New CD-Rom code. #1129

wants to merge 227 commits into from

Conversation

nicolasnoble
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.26316% with 136 lines in your changes missing coverage. Please review.

Project coverage is 20.46%. Comparing base (1e635d0) to head (32e74e5).
Report is 4 commits behind head on main.

❗ Current head 32e74e5 differs from pull request most recent head c25e5c3

Please upload reports for the commit c25e5c3 to get more accurate results.

Files Patch % Lines
src/core/sstate.cc 0.00% 65 Missing ⚠️
src/core/cdrom.h 68.75% 15 Missing ⚠️
src/gui/gui.cc 0.00% 9 Missing ⚠️
src/supportpsx/iec-60908b.h 64.00% 9 Missing ⚠️
src/core/psxinterpreter.cc 81.81% 6 Missing ⚠️
src/core/mdec.cc 0.00% 5 Missing ⚠️
src/core/luaiso.cc 33.33% 4 Missing ⚠️
src/core/psxdma.h 20.00% 4 Missing ⚠️
src/core/gte.cc 0.00% 2 Missing ⚠️
src/core/isoffi.lua 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1129       +/-   ##
===========================================
+ Coverage    9.94%   20.46%   +10.52%     
===========================================
  Files         448      449        +1     
  Lines      132699   132249      -450     
===========================================
+ Hits        13200    27069    +13869     
+ Misses     119499   105180    -14319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnbaumann johnbaumann mentioned this pull request Dec 6, 2022
Draft
nicolasnoble and others added 25 commits December 6, 2022 21:38
@nicolasnoble
First pieces of the state machine in place.
ff0c7f8
@nicolasnoble
Merge branch 'main' into fuckit
7ab43b5
@nicolasnoble
Bit more code here.
6abd655
@nicolasnoble
Merge branch 'fuckit' of github.com:nicolasnoble/pcsx-redux into fuckit
12daafd
@nicolasnoble
Merge remote-tracking branch 'origin/main' into fuckit
ba42c39
@nicolasnoble
Advancing in the new CD-Rom code.
ed7b668
@nicolasnoble
Adding cdlSetLoc.
9d818e6
@nicolasnoble
General cleanup.
43159ab
@nicolasnoble
Adding lid code.
e5f56dc
@nicolasnoble
More chrono helpers.
f3e746a
@nicolasnoble
ACK 0x18 handled.
4c2ef61
@nicolasnoble
More comments.
48298c8
@nicolasnoble
Adding read interrupt again.
8627aea
@nicolasnoble
Fixing clang build.
b117fce
@nicolasnoble
Figured timings for command 10.
16ec008
@nicolasnoble
Adding basic cdrom test.
2957f83
@nicolasnoble
Forgot new file.
9949041
@nicolasnoble
Another forgotten file.
0a1ef58
@nicolasnoble
Adding delayed init test.
caaf0cc
@nicolasnoble
Enhancing test.
732ae86
@nicolasnoble
Further enhancing test.
b15fced
@nicolasnoble
Making the enhanced test pass.
574b2cd
@nicolasnoble
Merge branch 'fuckit' of github.com:nicolasnoble/pcsx-redux into fuckit
2026966
@nicolasnoble
Forgot to commit this file...
7acd39b
@nicolasnoble
Swapping Init <--> Reset.
7d984c2
@nicolasnoble
Merge branch 'main' of http://github.com/grumpycoders/pcsx-redux into…
0293274 
… fuckit
@nicolasnoble
Even raw MODE2 should probably regenerate ECC/EDC.
44c3ef5
@nicolasnoble
Adding convenience cast method to LuaBuffer.
93a52f2
@nicolasnoble
Further simplifying run command for test case generation.
3ffd75a
@nicolasnoble
Generate XA audio wave in the test iso.
ed239cd
@nicolasnoble
Adding command 0 'support'.
6bfe493
@nicolasnoble
Merge remote-tracking branch 'upstream/main' into fuckit
c9bfa68
@nicolasnoble
Adding test for over-reading of response buffers.
f1f4381
@nicolasnoble
Making buffer overrun test pass.
aae23e7
@nicolasnoble
Tweaking test a bit more.
71ba79b
@nicolasnoble
Better tweak.
0d19019
@nicolasnoble
Being a bit more annoying with this test.
120e856
@nicolasnoble
Making test pass.
8ff2072
@nicolasnoble
Adding hexdump utility.
69fa64e
@nicolasnoble
Adding full mode2 read test.
6b43700
@nicolasnoble
Merge remote-tracking branch 'upstream/main' into fuckit
32e74e5
@nicolasnoble
Merge remote-tracking branch 'upstream/main' into fuckit
d7ae274 
# Conflicts:
#	.github/workflows/linux-build.yml
@nicolasnoble
Merge remote-tracking branch 'upstream/main' into fuckit
c25e5c3
@nicolasnoble
Adding some CDDA tests.
b30f74b
@nicolasnoble
Merge remote-tracking branch 'upstream/main' into fuckit
a6dd75e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbaumann johnbaumann Awaiting requested review from johnbaumann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasnoble @ramapcsx2 @caldog20