Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIO1 Synchronization Fixes #1124

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

caldog20
Copy link
Contributor

@caldog20 caldog20 commented Dec 3, 2022

  • More strict synchronization between server/client to help games stay in sync (especially games that sync on vsync)
  • Help to balance out FPS between both instances while maintaining connection
  • Implement missing interrupt mechanisms (DSR, TX interrupts)
  • Disable Nagles by setting TCP_NODELAY on libuv handles in UvFifo and UvFifoListener
  • tidy up and format code

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 16.39% // Head: 16.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4ba3784) compared to base (53bcf36).
Patch coverage: 1.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   16.39%   16.38%   -0.01%     
==========================================
  Files         362      363       +1     
  Lines      115725   115680      -45     
==========================================
- Hits        18971    18957      -14     
+ Misses      96754    96723      -31     
Impacted Files Coverage Δ
src/core/psxhw.cc 19.62% <ø> (+0.91%) ⬆️
src/core/sio1.cc 0.00% <0.00%> (ø)
src/support/uvfile.cc 8.09% <0.00%> (-0.03%) ⬇️
src/core/sio1.h 16.21% <4.34%> (+0.21%) ⬆️
src/spu/miniaudio.h 27.77% <0.00%> (-16.67%) ⬇️
src/spu/interface.h 15.38% <0.00%> (-7.70%) ⬇️
src/spu/miniaudio.cc 72.03% <0.00%> (-3.39%) ⬇️
src/core/psxcounters.cc 73.26% <0.00%> (-1.49%) ⬇️
src/gui/widgets/sio1.cc 0.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant