Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation/safety of hasExt #190

Open
thomasjm opened this issue Jun 5, 2020 · 0 comments
Open

Improve documentation/safety of hasExt #190

thomasjm opened this issue Jun 5, 2020 · 0 comments

Comments

@thomasjm
Copy link

thomasjm commented Jun 5, 2020

The hasExt function leaves something to be desired with respect to documentation and type safety. Commit 8288d27 left it in an even worse state, with a reference to the hasExtension function that had been reexported from the now-removed system-filepath dependency. Even worse, that commit introduced a sneaky semantics change where the first arg needs to begin with a dot when before it didn't. It would be good to at least document whether the dot is required, or even better make it foolproof with the type signature somehow.

hasExt :: Text -> FilePath -> Bool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant