Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work on Windows any more #176

Closed
hsenag opened this issue Jun 10, 2018 · 13 comments
Closed

doesn't work on Windows any more #176

hsenag opened this issue Jun 10, 2018 · 13 comments

Comments

@hsenag
Copy link
Contributor

hsenag commented Jun 10, 2018

Since commit 94acbcc, shelly depends on 'unix' so doesn't build on Windows any more. Is this intentional? @rocketnik

@rocketnik
Copy link
Contributor

Sorry, my fault. No it is not. Will fix it in the next days.

@hsenag
Copy link
Contributor Author

hsenag commented Jun 11, 2018

No problem, thanks. It's unusable anyway thanks to #177, but one step at a time :-)

@rocketnik
Copy link
Contributor

Could you please check if
#178
works for your windows machine too?

nekketsuuu added a commit to nekketsuuu/SatysfiFilter that referenced this issue Oct 21, 2018
shelly-1.8.1 doesn't work on Windows. See <gregwebs/Shelly.hs#176>.
cdornan added a commit to iconnect/regex that referenced this issue Dec 14, 2018
shelly-1.8.1 is broken for windows:

  gregwebs/Shelly.hs#176
@dtaskoff
Copy link

dtaskoff commented Dec 27, 2018

Please downgrade the version in LTS Haskell. LTS Haskell shouldn't contain packages that can't be compiled.

@mihaimaruseac
Copy link

Shelly downgraded in LTS 13.4 to 1.8.0

@ozgurakgun
Copy link

Hijacking this issue, please let me know if you prefer a new issue.

  • 1.8.0 did not depend on unix, and I was using it on Windows.
  • 1.8.1 now depends on unix, and hence doesn't build on Windows.

Was this on purpose? Can it be avoided?

@gregwebs
Copy link
Owner

It would be great to have a Windows use submit a fix for this

@hsenag
Copy link
Contributor Author

hsenag commented Mar 28, 2020

I did look into it a bit when I first ran into this, and I can't remember exactly what I found, but I don't think it was easy. Just rolling back the change that introduced the unix dependency is my only real suggestion.

@gregwebs
Copy link
Owner

Can you send a tested pull request?

@hsenag
Copy link
Contributor Author

hsenag commented Mar 28, 2020

Are you happy with the principle of rolling back the change? If so I'll do it when I have a chance, might not be immediately.

@gregwebs
Copy link
Owner

gregwebs commented Mar 29, 2020 via email

@andreasabel
Copy link
Collaborator

Could this issue be solved by using unix-compat instead of unix?

@andreasabel
Copy link
Collaborator

I think this is fixed. Please reopen with new information if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants