-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't work on Windows any more #176
Comments
Sorry, my fault. No it is not. Will fix it in the next days. |
No problem, thanks. It's unusable anyway thanks to #177, but one step at a time :-) |
Could you please check if |
shelly-1.8.1 doesn't work on Windows. See <gregwebs/Shelly.hs#176>.
shelly-1.8.1 is broken for windows: gregwebs/Shelly.hs#176
Please downgrade the version in LTS Haskell. LTS Haskell shouldn't contain packages that can't be compiled. |
Shelly downgraded in LTS 13.4 to 1.8.0 |
It would be great to have a Windows use submit a fix for this |
I did look into it a bit when I first ran into this, and I can't remember exactly what I found, but I don't think it was easy. Just rolling back the change that introduced the unix dependency is my only real suggestion. |
Can you send a tested pull request? |
Are you happy with the principle of rolling back the change? If so I'll do it when I have a chance, might not be immediately. |
Sounds good to me
…On Sat, Mar 28, 2020, 1:44 PM Ganesh Sittampalam ***@***.*** wrote:
Are you happy with the principle of rolling back the change? If so I'll do
it when I have a chance, might not be immediately.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAJHYEYCARM43AQVC2KFLRJZOUXANCNFSM4FEGRSFQ>
.
|
Could this issue be solved by using |
I think this is fixed. Please reopen with new information if you disagree. |
Since commit 94acbcc, shelly depends on 'unix' so doesn't build on Windows any more. Is this intentional? @rocketnik
The text was updated successfully, but these errors were encountered: