New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PR Previews from trusted forks do not deploy. #3072

Open

damienwebdev opened this issue Sep 17, 2024 · 2 comments

Assignees

Labels

bug

Member

damienwebdev commented Sep 17, 2024

🐛 Bug report

See: https://github.com/graycoreio/daffodil/actions/runs/10856140779

damienwebdev added the bug label

damienwebdev self-assigned this

Member Author

damienwebdev commented Sep 26, 2024

It turns out, they do deploy. https://github.com/graycoreio/daffodil/actions/runs/11054066664/job/30709966620

However, it doesn't create a deployment in Github.

Additionally, we should lock this down to trusted forks.

Member Author

damienwebdev commented Sep 26, 2024

The ref needs to be changed: https://github.com/graycoreio/daffodil/blob/develop/.github/workflows/deploy_preview.yml#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment