Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop v from plugin versions to make it work with all the surrounding tooling #5028

Closed
tolzhabayev opened this issue Sep 17, 2024 · 1 comment · Fixed by #5051
Closed

Drop v from plugin versions to make it work with all the surrounding tooling #5028

tolzhabayev opened this issue Sep 17, 2024 · 1 comment · Fixed by #5051
Labels
bug Something isn't working more info needed

Comments

@tolzhabayev
Copy link

What went wrong?

What happened:

What did you expect to happen:

  • Drop the v from the future plugin versions, it is not needed and it breaks a lot of areas (gcom-api, plugins cli, etc.) that do not expect it to be there.

How do we reproduce it?

Try installing it via plugins cli or env variables grafana/grafana#92669 (comment)

Grafana OnCall Version

latest

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

@joeyorlando
Copy link
Contributor

joeyorlando commented Sep 23, 2024

This has been patched starting in v1.9.27 (via #5051):

❯ grafana cli plugins list-versions grafana-oncall-app
1.9.27
v1.9.26
v1.9.25
v1.9.24
v1.9.23
v1.9.22
v1.9.21
v1.9.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working more info needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants