Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add 'Unknown' wh type for EOL/critmass states #188

Open
vlanf opened this issue Sep 8, 2023 · 5 comments
Open

[Feature request] Add 'Unknown' wh type for EOL/critmass states #188

vlanf opened this issue Sep 8, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vlanf
Copy link

vlanf commented Sep 8, 2023

Living in WH-space we usually have following scenario:

  1. System has some wh.
  2. This wh is reaching the end of natural lifetime, or on verge of collaplse.
  3. I don't want to jump inside, but I would like to mark it with EOL and crit-mass states.

Currently I'm just writing this information in description of signature, but it would be more visually preferable to see 'Unknown' wh on the map with connection, marked appropriately. Alternatively I can use random system with name alias 'Unknown', but it is a workaround and has drawbacks (incorrect system type and statics). It will be more convenient to have separate 'Unknown' WH type.

@TyrHeimdalEVE
Copy link
Collaborator

You and me both, dude!

I think the quickest solution to this one is to have a K-FU-IM-NOT-JUMPING-THAT-EOL-HOLE option as WH type and that renders it in say a colored column.

We can technically add it as a Mark EOL button, that switches to Unmark EOL if someone does decide to scan it afterwards.

I'm not so sure I'd have it as an actual node on the map taking up space for no valid reason. Would you agree that the above is sufficient?

@TyrHeimdalEVE TyrHeimdalEVE added enhancement New feature or request good first issue Good for newcomers labels Sep 8, 2023
@vlanf
Copy link
Author

vlanf commented Sep 8, 2023

I suggest adding new node on map because I think it's technically easier to implement, to reuse current functionality with color-rendering signature on system type in signatures module (pic below). To not take much space, new node can be much smaller because it has no info, just text or even icon.

Your approach is ok, too.

So, currently it renders like:

image

You suggest to add new buttons here (when clicking 'unknown' in 'leads to' column) ?

image

If so, in case of valid connection to other system, implementation should set these states (EOL, critmass) to actual connection. Or don't show buttons for existing connection. Note that there's rendering option for 'reduced' wh size (in yellow), may be it will be better to add this variant, too.

I'm not good with JS and code base here, so may be you know what is better approach for existing code.

@vlanf
Copy link
Author

vlanf commented Sep 8, 2023

Also may be this issue should be linked with #159 ?

@ScyllPoesis
Copy link

Would love to see this implemented as well. Constantly come up against the same dilemma as OP, and have to resort to using the description box to mark it EOL for now.

@samoneilll
Copy link

Hey team, so is the solution just to have an "unknown" option in that drop-down?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants