From 29da6de19d49c01ef23eb7d912bcdba5fcb83323 Mon Sep 17 00:00:00 2001 From: kolea2 <45548808+kolea2@users.noreply.github.com> Date: Wed, 27 May 2020 12:59:40 -0400 Subject: [PATCH] chore(fix): unflake MetricsTracerTest (#313) * chore(fix): unflake MetricsTracerTest * chore(fix): unflake MetricsTracerTest * chore(fix): unflake MetricsTracerTest * chore(fix): unflake MetricsTracerTest * review feedback * review feedback --- .../bigtable/data/v2/stub/metrics/MetricsTracerTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerTest.java b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerTest.java index 9314391afa..9fd78c5cd5 100644 --- a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerTest.java +++ b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerTest.java @@ -237,7 +237,10 @@ public Object answer(InvocationOnMock invocation) throws Throwable { getAggregationValueAsLong( RpcViewConstants.BIGTABLE_READ_ROWS_FIRST_ROW_LATENCY_VIEW, ImmutableMap.of()); - assertThat(firstRowLatency).isIn(Range.closed(beforeSleep, elapsed - afterSleep)); + + // adding buffer time to the upper range to allow for a race between the emulator and the client + // recording the duration + assertThat(firstRowLatency).isIn(Range.closed(beforeSleep, elapsed - afterSleep / 2)); } @Test