New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewSink constructor should accept an interface #20

Open

tam7t opened this issue Sep 1, 2021 · 0 comments

Contributor

tam7t commented Sep 1, 2021

https://pkg.go.dev/github.com/google/go-metrics-stackdriver#NewSink

currently only accepts a https://pkg.go.dev/cloud.google.com/go/monitoring/apiv3#MetricClient

which says:

Deprecated: Please use cloud.google.com/go/monitoring/apiv3/v2.

This was also mentioned #16 but would be a breaking change to the package.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment