Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protocmp for rpc testing #2

Open
tam7t opened this issue Nov 28, 2019 · 0 comments
Open

Use protocmp for rpc testing #2

tam7t opened this issue Nov 28, 2019 · 0 comments

Comments

@tam7t
Copy link
Contributor

tam7t commented Nov 28, 2019 •
edited
Loading

The expectations in stackdriver_test.go would be much more readable of a package like protocmp was used for ensuring the requests had the correct data.
@tam7t tam7t mentioned this issue Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tam7t