{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":52804750,"defaultBranch":"main","name":"breakpad","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-02-29T16:14:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1513901868.0","currentOid":""},"activityList":{"items":[{"before":"8668fcea0edb5fe5cf7d8562cee02e87486eb3c9","after":"e92bea30759edbae08205bccd14dc25bf1806f93","ref":"refs/heads/main","pushedAt":"2024-09-04T20:33:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[windows] dump_syms - Support ARM64 PDB\n\nChange-Id: I6a9cb5c5253abcd34cb72a035d280b7fd8a50372\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5836085\nReviewed-by: Nelson Billing ","shortMessageHtmlLink":"[windows] dump_syms - Support ARM64 PDB"}},{"before":"6b0c5b7ee1988a14a4af94564e8ae8bba8a94374","after":"8668fcea0edb5fe5cf7d8562cee02e87486eb3c9","ref":"refs/heads/main","pushedAt":"2024-09-04T19:15:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix bugs with alternative section naming on mac, and unpropagated\nsection information.\n\nChange-Id: I6f4e112a83aeee1e4cd525c1d1d0b9213ef2d09b\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5838157\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Fix bugs with alternative section naming on mac, and unpropagated"}},{"before":"eb6b3f89fd6261353797f52f2cd43346b1d724cf","after":"6b0c5b7ee1988a14a4af94564e8ae8bba8a94374","ref":"refs/heads/main","pushedAt":"2024-08-16T15:28:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[windows] Silence MSVC warning C4100 when building without zlib support\n\nAlso correct the indentation of the Deflate function to match the\nsurrounding code.\n\nBug: b/354710760\nChange-Id: I17e64b2f6390f673169a783e63505eb9df233a79\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5771532\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"[windows] Silence MSVC warning C4100 when building without zlib support"}},{"before":"1420017c7f9fb910a9ae878d7bf5a6423fba3c59","after":"eb6b3f89fd6261353797f52f2cd43346b1d724cf","ref":"refs/heads/main","pushedAt":"2024-07-30T19:02:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds Support for EC Zephyr Binaries\n\nThe text section header for EC Zephyr binaries is `text` instead of the\nstandard `.text`. As a result the file_id hash function was failing when\nattempting to generate a file id by hashing the contents of a Zephyr\nbinaries `text` section.\n\nThis change adds support for Zephyr binaries by having said hash\nfunction also check the `text` section in addition to `.text`.\n\nTest output: https://paste.googleplex.com/4708788542373888#l=20\n\nThree tests are listed as failing in the test output. This is a known\nunrelated issue caused by this commit: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5636127\n\nTEST=make check && dump_syms -a ~/some.zephyr.elf\nBUG=b:328511413\n\nChange-Id: I88882305a4c9ca18082ba2690ba1b22da03bd19d\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5732693\nReviewed-by: Forest Mittelberg \nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Adds Support for EC Zephyr Binaries"}},{"before":"680014b34edd1b6b631b79e84b4424185a693dde","after":"1420017c7f9fb910a9ae878d7bf5a6423fba3c59","ref":"refs/heads/main","pushedAt":"2024-07-26T18:24:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Revert \"[windows] Silence MSVC warning C4100 when building without zlib support\"\n\nThis reverts commit ee94d7f24bf1ac756c8db20b6d9e052acaa17e0c.\n\nReason for revert: Breaks Windows builds of Chromium.\n\nhttps://ci.chromium.org/ui/p/chromium/builders/try/win-rel/695756/overview\n\nOriginal change's description:\n> [windows] Silence MSVC warning C4100 when building without zlib support\n>\n> Bug: b/354710760\n> Change-Id: I0a5771795ca456cd07ad26038f005553875df641\n> Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5735099\n> Reviewed-by: Ivan Penkov \n> Reviewed-by: Ivan Penkov \n\nBug: b/354710760\nChange-Id: Ib49e06944934d467beaefb91411235eed020381a\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5742385\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Revert \"[windows] Silence MSVC warning C4100 when building without zl…"}},{"before":"ee94d7f24bf1ac756c8db20b6d9e052acaa17e0c","after":"680014b34edd1b6b631b79e84b4424185a693dde","ref":"refs/heads/main","pushedAt":"2024-07-26T14:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"upload_system_symbols: break into go packages\n\nThis will make reusing this code easier. Since there are multiple\npackages now, the build needs updating. A separate CL in Chromium will\nfollow this change.\n\nChange-Id: I8d95d13ea61d32684d0ef845c3d1da2cd6d4cd7f\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5742415\nReviewed-by: Mark Mentovai \nReviewed-by: Leonard Grey ","shortMessageHtmlLink":"upload_system_symbols: break into go packages"}},{"before":"81819541a78c49e9109d2267462775e801f89ce6","after":"ee94d7f24bf1ac756c8db20b6d9e052acaa17e0c","ref":"refs/heads/main","pushedAt":"2024-07-25T17:14:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[windows] Silence MSVC warning C4100 when building without zlib support\n\nBug: b/354710760\nChange-Id: I0a5771795ca456cd07ad26038f005553875df641\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5735099\nReviewed-by: Ivan Penkov \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"[windows] Silence MSVC warning C4100 when building without zlib support"}},{"before":"0c9811dd5d6d9f544c7a18fdac79b35a5faabcd1","after":"81819541a78c49e9109d2267462775e801f89ce6","ref":"refs/heads/main","pushedAt":"2024-07-19T19:28:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[windows] Include-what-you-use fixes in http_upload.{cc,h}\n\nBug: b/353869880\nChange-Id: I7dd2d432032099c77410ce67a0fce6c7a71b473f\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5720428\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"[windows] Include-what-you-use fixes in http_upload.{cc,h}"}},{"before":"7f3ccb77337bc9d35b252fcddc4f6a983f80dd6b","after":"0c9811dd5d6d9f544c7a18fdac79b35a5faabcd1","ref":"refs/heads/main","pushedAt":"2024-07-17T18:56:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds NDS32 Architecture Support to dump_syms\n\nNDS32 is a relatively uncommon architecture that is used on a\nsignificant chunk of our ChromeOS EC Microprocessors. NDS32 symbol table\ngeneration was already supported, but would fail due to \"Unrecognized ELF\nmachine architecture\". This change fixes that.\n\nTEST=dump_syms -a some.nds32.elf\nBUG=b:328511413\n\nChange-Id: I3e9ae900be483c957a824166d24e2d5db240b64a\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5718928\nReviewed-by: Forest Mittelberg \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Adds NDS32 Architecture Support to dump_syms"}},{"before":"466cc92bc247862a2c9ad3b0051eab4dd081c355","after":"7f3ccb77337bc9d35b252fcddc4f6a983f80dd6b","ref":"refs/heads/main","pushedAt":"2024-07-12T18:53:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Windows] PDBSourceLineWriter improvements\n\nCOM calls that return a BSTR via an out param pass ownership of the\nstring's underlying memory to the caller. It is the caller's\nresponsibility to free the memory via SysFreeString. Be sure to use\nCComBSTR in all such cases, so that this happens upon destruction of the\nCComBSTR. This CL fixes three BSTR memory leaks.\n\nThe inline_origins_ member maps an inline origin's name to a unique\nnumerical identifier. Simplify the container by mapping a name only to\nan id rather than a name to a struct holding the name and id.\n\nThese origins are printed ordered by id. Rather than using a std::set to\ncreate a container sorted by id, leverage the fact that ids are ints\nthat are assigned sequentially to create the reverse mapping in a\nstd::vector. This greatly reduces heap usage, and reduces complexity to\nO(N).\n\nCombined, these changes reduce commit charge by 26% and runtime by 10%\nwhen processing chrome.dll for a 32-bit win-dcheck build.\n\nChange-Id: Ib8d6540c74622500989f1dc06f705d6846be303f\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682242\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"[Windows] PDBSourceLineWriter improvements"}},{"before":"2c5ac8a88e58b294443df92f5be08915da951067","after":"466cc92bc247862a2c9ad3b0051eab4dd081c355","ref":"refs/heads/main","pushedAt":"2024-07-12T18:01:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[symupload] Upload compressed symbol files on Windows\n\nWhen supported at build-time (by defining HAVE_ZLIB and ensuring that\nzlib.h is in the include path), use zlib to deflate symbol files before\nuploading. In case of failure (or when not supported), fall-back to\nuploading the raw data as before.\n\nBug: chromium:349736158\nChange-Id: I9345b87e42a03c87a43247e418b5cc05cd19b2b5\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5701147\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"[symupload] Upload compressed symbol files on Windows"}},{"before":"9ad37adcc5218698e3d24710491833a5e89d1284","after":"2c5ac8a88e58b294443df92f5be08915da951067","ref":"refs/heads/main","pushedAt":"2024-07-08T18:41:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[symupload] Log details to stderr on failure\n\nOn success, symupload emits details such as the debug identifier. Emit a\nvery similar message to stderr on failure, as this information may also\nbe useful when diagnosing upload failures.\n\nBug: chromium:349736158\nChange-Id: Ic3b5316283e4603dca815bd85a2fd51516fbcca8\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682842\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"[symupload] Log details to stderr on failure"}},{"before":"8470d392a2fdb73b8f838196ba3c09cf8c95d3ac","after":"9ad37adcc5218698e3d24710491833a5e89d1284","ref":"refs/heads/main","pushedAt":"2024-07-05T11:52:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Windows] Improve diagnostic logging in HTTPUpload\n\nLog the operation and Windows and/or WinInet error in case of failure.\nAlso remove use of an intermediate buffer in ReadResponse.\n\nBug: chromium:349736158\nChange-Id: I51de506e1636e28a24a5c6dd579ebbfcd07c0345\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5679269\nReviewed-by: Primiano Tucci ","shortMessageHtmlLink":"[Windows] Improve diagnostic logging in HTTPUpload"}},{"before":"63c61b6f5a1d823ff944e1c58e1b341d27e9f0fe","after":"8470d392a2fdb73b8f838196ba3c09cf8c95d3ac","ref":"refs/heads/main","pushedAt":"2024-07-03T20:00:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Support large files in the Windows variant of HTTPUpload\n\nThe STL uses fseek and ftell, which don't work for files with lengths\ngreater than that which a long can accommodate. Avoid std::fstream, and\ninstead use Win32 APIs directly to read files in the HTTP uploader.\nAdditionally:\n\n- Halve the heap impact of reading files by reading directly into the\n request.\n- Hint to the Windows cache manager that the file will be read\n sequentially, thereby reducing the impact of the read on the system.\n\nBug: chromium:349736158\nChange-Id: I260836946069f6867c20a9ba8ea6043dd041c69c\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5675886\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Support large files in the Windows variant of HTTPUpload"}},{"before":"e0a3a76758874bdc04e7a32e254403332f515a2d","after":"63c61b6f5a1d823ff944e1c58e1b341d27e9f0fe","ref":"refs/heads/main","pushedAt":"2024-07-03T19:08:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"handle write failure in minidump-2-core\n\nChange-Id: I0636f315d300a1738a9f12f28d693292a836dc56\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5539174\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"handle write failure in minidump-2-core"}},{"before":"c8318f06d3a48b0af37862b29fbeeeae8258dbed","after":"e0a3a76758874bdc04e7a32e254403332f515a2d","ref":"refs/heads/main","pushedAt":"2024-06-19T00:14:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Allows setting maximum number of threads to process.\n\nBy default, there is no limit and all threads will be processed. If set to a positive integer (via set_max_thread_count), the minidump processor will stop once that limit is reached. The limit will be ignored if the crashing/requesting thread is above the specified limit.\n\nThe original thread count is stored in the ProcessState and can be\nacessed via the original_thread_count() method.\n\nChange-Id: I6f0f173e5ad163aa7b2be76780b4a86e4932fc17\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5641257\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Allows setting maximum number of threads to process."}},{"before":"527331a471207d28d015e210c12fb8bb8b6732fd","after":"c8318f06d3a48b0af37862b29fbeeeae8258dbed","ref":"refs/heads/main","pushedAt":"2024-06-18T22:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"ARM: use r11 as frame pointer during stack unwind\n\nBug: b/340226382\nChange-Id: Idb3d6e502a5a1e25179c3d5f2a19ac4cd79cd103\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5636127\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"ARM: use r11 as frame pointer during stack unwind"}},{"before":"69f9a4ef3ce4f5b40e3b202302a076cc2e96ec0b","after":"527331a471207d28d015e210c12fb8bb8b6732fd","ref":"refs/heads/main","pushedAt":"2024-05-31T12:07:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Wait for SIGSTOP during attach, reinjecting unrelated signals\n\nPTRACE_ATTACH sends SIGSTOP to this thread. However, on waitpid() we may\nreceive some other pending signal sooner than this SIGSTOP. Therefore,\nwe need to call waitpid() until we receive SIGSTOP.\n\nSignals other than SIGSTOP that are received need to be reinjected with\nPTRACE_CONT, or they will otherwise get lost.\n\nIf we do not wait for the SIGSTOP signal in waitpid(), this signal will\nbe delivered after PTRACE_DETACH, and the thread will enter the\n\"T (stopped)\" state.\n\nSee ptrace(2) manpage, under the section \"Attaching and detaching\".\n\nChange-Id: Ifcc89cc34086988d496cd31f5dc63e9fceebcaf6\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5582149\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"Wait for SIGSTOP during attach, reinjecting unrelated signals"}},{"before":"9dd7d3497e7f6d58e9459e0e6be28b1d4b41d35f","after":"69f9a4ef3ce4f5b40e3b202302a076cc2e96ec0b","ref":"refs/heads/main","pushedAt":"2024-05-23T18:39:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix format string for uint64_t and size_t data.\n\nChange-Id: I9086396561ea7870cfd55ab62c416d2944f0d46b\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5564823\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"Fix format string for uint64_t and size_t data."}},{"before":"417f5dbd0af9f96ca3e5faa99f41c064b89b40fd","after":"9dd7d3497e7f6d58e9459e0e6be28b1d4b41d35f","ref":"refs/heads/main","pushedAt":"2024-05-23T16:55:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Add error handling for common failure case seen processing debug symbols\n\nPropagates error from ProcessDIEs to the top level where it can be\nhandled.\n\nChange-Id: Ib6ba171ff642a898c75233a3f70995837c6c0552\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5564423\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Add error handling for common failure case seen processing debug symbols"}},{"before":"54986d34d4611983243f8401563ff022b649afbf","after":"417f5dbd0af9f96ca3e5faa99f41c064b89b40fd","ref":"refs/heads/main","pushedAt":"2024-05-13T17:46:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"preserve NT_FILE note converting md to core\n\nbreakpad produced Minidumps have all the information needed to preserve the\nNT_FILE note that linux coredumps normally have, but are not currently\nincluded when converting using minidump-2-core. This adds a step to coredump\ngeneration to add the note to the coredump. This change allows for two\nimprovements when loading coredumps into gdb:\n\n1. for PIE code (default compilation now for gcc) gdb is now able to properly\nvalidate the PIE displacement and apply it to the debugging session, providing\nbetter stack trace quality.\n2. gdb can now pick up so symbol files automatically without relying on the\nscripting normally recommended by google for breakpad where add-symbol-file\nis used to manually load symbols.\n\nBug: https://crbug.com/google-breakpad/766\nChange-Id: I8cb25246dce0ae3492eedd6d3a4efcf1783d414d\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463435\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"preserve NT_FILE note converting md to core"}},{"before":"6fe410dcd5ddacec9554e8c217f3c37d0362da21","after":"54986d34d4611983243f8401563ff022b649afbf","ref":"refs/heads/main","pushedAt":"2024-05-10T00:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds a custom Module ID flag to dump_syms\n\nTEST=make check\nBUG=b:328511413\n\nChange-Id: I09d4c5e92213501b647311b804e65f272772bbaf\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5523975\nReviewed-by: Ivan Penkov \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Adds a custom Module ID flag to dump_syms"}},{"before":"f88a1aa2af1d1fd795716365245761b89041139d","after":"6fe410dcd5ddacec9554e8c217f3c37d0362da21","ref":"refs/heads/main","pushedAt":"2024-05-08T22:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds a Flag to Perserve Address Offset in dump_syms\n\nBy default, the .code section start address is normalized to zero,\nand subsequently the address of all functions and lines are adjusted\naccordingly. This change adds a command line flag that perserves the\noriginal addresses. This is a requirement for those that may wish to use\nthe crash resolver, but do not have a minidump file to work with (most commonly in firmware).\n\nTEST=make check\nBUG=b:328511413\n\nChange-Id: Id7c477196ffed7fd319029b28ed2607192249c6c\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5519154\nReviewed-by: Rob Barnes \nReviewed-by: Ivan Penkov \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Adds a Flag to Perserve Address Offset in dump_syms"}},{"before":"a8a43bad6fdb2d63b623862bea8f6bc959d8edc9","after":"f88a1aa2af1d1fd795716365245761b89041139d","ref":"refs/heads/main","pushedAt":"2024-04-24T17:29:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Use zlib's uncompress() to uncompress headers\n\nChange-Id: Ib785633b229d3f17534da9b0de93255e80fddd70\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5484086\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Use zlib's uncompress() to uncompress headers"}},{"before":"e5dc1f86b2defc8f76b56fb473b804e42e75c41d","after":"a8a43bad6fdb2d63b623862bea8f6bc959d8edc9","ref":"refs/heads/main","pushedAt":"2024-04-18T16:38:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Prefer to use .note.gnu.build-id section as ElfBuildId\n\nSummary:\nAndroid prefers `.note.gnu-build-id`[0] as BuildId than anyother PT_NOTE\nphdrs. This CL tries to read ElfBuildId from `.note.gnu.build-id` first\nto fix the BuildId mismatch issue between Android tombstone report and\nbreakpad symbol file.\n\ne.g\n```\nSection Headers:\n [Nr] Name Type Address Offset\n Size EntSize Flags Link Info Align\n [ 0] NULL 0000000000000000 00000000\n 0000000000000000 0000000000000000 0 0 0\n [ 1] .note.androi[...] NOTE 0000000000000270 00000270\n 0000000000000018 0000000000000000 A 0 0 4\n [ 2] .note.hwasan[...] NOTE 0000000000000288 00000288\n 000000000000001c 0000000000000000 A 0 0 4\n [ 3] .note.gnu.bu[...] NOTE 00000000000002a4 000002a4\n 0000000000000020 0000000000000000 A 0 0 4\n\n$ readelf -x .note.hwasan.globals\nHex dump of section '.note.hwasan.globals':\n 0x00000288 08000000 08000000 03000000 4c4c564d ............LLVM\n 0x00000298 00000000 98890100 409d0100 ........@...\n\n$ readelf -x .note.gnu.build-id\nHex dump of section '.note.gnu.build-id':\n 0x000002a4 04000000 10000000 03000000 474e5500 ............GNU.\n 0x000002b4 a4eb3625 c1db6452 1e881973 bfdff9bd ..6%..dR...s....\n```\n\nThe BuildId in tombstone:\n```\nlibartbase.so (BuildId: c7e463b51b0898d442269a421353bdbd)\n```\n\nBut the breakpad dump_syms got:\n```\nMODULE Linux arm64 000189989D40000100000000000000000 libartbase.so\nINFO CODE_ID 98890100409D0100\n`````\n\n[0]\nhttps://cs.android.com/android/platform/superproject/main/+/main:system/unwinding/libunwindstack/ElfInterface.cpp;l=423-427;drc=3d19fbcc09b1b44928639b06cd0b88f735cd988d\n\nChange-Id: I01e3514e0e2a1ea163c03093055284448ed4e89c\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463566\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Prefer to use .note.gnu.build-id section as ElfBuildId"}},{"before":"a86123f1e7cc27d0e3de185467b3495cf0851f54","after":"e5dc1f86b2defc8f76b56fb473b804e42e75c41d","ref":"refs/heads/main","pushedAt":"2024-03-29T15:38:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Reduce logging during minidump processing\n\nChange-Id: Ie62795137770cff7cda7494c5527457b1e355897\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5402921\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Reduce logging during minidump processing"}},{"before":"76788faa4ef163081f82273bfca7fae8a734b971","after":"a86123f1e7cc27d0e3de185467b3495cf0851f54","ref":"refs/heads/main","pushedAt":"2024-03-19T20:45:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix some undefined behavior\n\nIt is undefined behavior to access mis-aligned pointers.\n\nChange-Id: I06f676c6a4b92a4bb58db76b8f23750d18148940\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5380937\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Fix some undefined behavior"}},{"before":"26666b80bac3254787976bb7be52db3f4a303663","after":"76788faa4ef163081f82273bfca7fae8a734b971","ref":"refs/heads/main","pushedAt":"2024-03-12T20:28:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Print better error messages in parts of CompilationUnit\n\nChange CompilationUnit::SkipAttribute() and\nCompilationUnit::ProcessOffsetBaseAttribute() to print the unknown form\ntypes they encounter.\n\nAlong the way, fix various formatting issues, stray trailing spaces, and\nupdate some NULLs to nullptrs.\n\nChange-Id: I5b3e72c9c6c9cb31e8a930e54418adb74b02f6c2\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5366242\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Print better error messages in parts of CompilationUnit"}},{"before":"f032e4c3b4eaef64432482cb00eb0c3df33cde48","after":"26666b80bac3254787976bb7be52db3f4a303663","ref":"refs/heads/main","pushedAt":"2024-03-12T17:46:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Check for failed seek when skipping x86 xstate data\n\nAfter reading minidump context with x86 xstate data, we seek past it, so\nthere needs to be a check to see that the seek operation did not fail.\n\nChange-Id: I8ed4394e452c435234116d97fd65856345cb618a\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5324600\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"Check for failed seek when skipping x86 xstate data"}},{"before":"b48a2d4a8ed40024d38502db5aeabd3ab6876687","after":"f032e4c3b4eaef64432482cb00eb0c3df33cde48","ref":"refs/heads/main","pushedAt":"2024-02-22T00:22:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Addressing a potential integer underflow in minidump.cc and stackwalker_arm64.cc\n\nAlso, defining __STDC_FORMAT_MACROS before including \n\nChange-Id: Ia25c4353412ca70512efef5e98670687ab575750\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5310977\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Addressing a potential integer underflow in minidump.cc and stackwalk…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wNFQyMDozMzozOS4wMDAwMDBazwAAAAStJA36","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMi0yMlQwMDoyMjozNC4wMDAwMDBazwAAAAQBbjps"}},"title":"Activity · google/breakpad"}