Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "rebase" and "merge" configurable per repository #4848

Open
koppor opened this issue Sep 7, 2024 · 1 comment
Open

Make "rebase" and "merge" configurable per repository #4848

koppor opened this issue Sep 7, 2024 · 1 comment
Labels
enhancement An improvement to an existing feature

Comments

@koppor
Copy link

koppor commented Sep 7, 2024

Version

0.12.26

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

It seems, that currently GitButler does rebasing when clicking on "Update".

Side comment: This is wished by #3598 - and it seems to be implemented.

In our project setting, we do not "like" that something is force pushed. For us, the merge commits are the way to go. Because: We want to know the context the developer had when coding. A "rebase" destroys this.

How to reproduce

No response

Expected behavior

Since there are fans of rebase and fans of merge, it would be nice if one could *configure, what happens when one clicks "Update" at "Workspace": rebase or merge. Similar setting than pull.rebase

The most advanced solution would be that GitButler follows the respective git configuration: pull.rebase and branch.<branchname>.rebase (<branchname> being the integration branch name)

Relevant log output

No response

@koppor koppor added the bug Something isn't working label Sep 7, 2024
@Byron Byron added enhancement An improvement to an existing feature and removed bug Something isn't working labels Sep 8, 2024
@Byron
Copy link
Collaborator

Byron commented Sep 8, 2024

Thanks a lot for the suggestion!

I really like the idea of respecting existing Git configuration as much as possible.
Right now, I think this can already be controlled on a per-lane basis like so:

Screenshot 2024-09-08 at 10 23 09

If Allow rebasing is off, a merge-commit will be created instead.

But even if this solves the problem stated here, I wonder if it would make sense for GitButler to pre-populate this setting (i.e. what should be the default for new virtual branches) based on the closest Git configuration that it can find.

CC @krlvi

@koppor koppor changed the title Make "rebase" and "merge" configurable Make "rebase" and "merge" configurable per repository Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants