#2023 - Ajout d'un champ adresse du candidat dans le formulaire de mini stage #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementLmd
changed the title
ClementLmd
commented
Sep 24, 2024
| @@ -237,6 +238,15 @@ const beneficiarySummary = ( | |||
| fields["signatories.beneficiary.birthdate"].label, | |||
| displayDate(convention.signatories.beneficiary.birthdate), | |||
| ], | |||
| ...(convention.internshipKind === "mini-stage-cci" && | |||
| convention.signatories.beneficiary.address | |||
There was a problem hiding this comment.
je n'ai pas trouvé d'autres moyens que ça pour pouvoir utiliser addressDtoToString
There was a problem hiding this comment.
il y a déjà la condition convention.internshipKind === "mini-stage-cci" juste en dessous (ligne 250), je pense que tu peux fusionner ton ajout avec
ClementLmd
force-pushed
the
2023-etq-candidat-pour-un-mini-stage-je-peux-indiquer-mon-adresse-dans-le-formulaire-du-mini-stage
branch
from
18ed3e5
to
495eac5
Compare
ClementLmd
temporarily deployed
to
review-app
GitHub Actions
Inactive
ClementLmd
temporarily deployed
to
review-app
GitHub Actions
Inactive
|
Review app: |
celineung
reviewed
Sep 27, 2024
| @@ -237,6 +238,15 @@ const beneficiarySummary = ( | |||
| fields["signatories.beneficiary.birthdate"].label, | |||
| displayDate(convention.signatories.beneficiary.birthdate), | |||
| ], | |||
| ...(convention.internshipKind === "mini-stage-cci" && | |||
| convention.signatories.beneficiary.address | |||
There was a problem hiding this comment.
il y a déjà la condition convention.internshipKind === "mini-stage-cci" juste en dessous (ligne 250), je pense que tu peux fusionner ton ajout avec
| @@ -76,6 +77,22 @@ export const minorBeneficiaryHasRepresentative = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| export const shouldValidateBeneficiaryAddressAndParse = ( | |||
There was a problem hiding this comment.
Suggested change
| export const shouldValidateBeneficiaryAddressAndParse = ( | |
| export const validateBeneficiaryAddressAndParse = ( |
celineung
reviewed
Sep 27, 2024
Comment on lines
+309
to
+314
| "signatories.beneficiary.address": { | ||
| label: "Adresse du candidat", | ||
| id: beneficiarySectionIds.address, | ||
| placeholder: "Ex : 10 Rue de la Paix, 75001 Paris", | ||
| required: true, | ||
| }, |
There was a problem hiding this comment.
Ce champ est seulement obligatoire dans le cas où le bénéficiaire habite en Auvergne Rhône Alpe.
Donc je propose de mettre ici:
Suggested change
| "signatories.beneficiary.address": { | |
| label: "Adresse du candidat", | |
| id: beneficiarySectionIds.address, | |
| placeholder: "Ex : 10 Rue de la Paix, 75001 Paris", | |
| required: true, | |
| }, | |
| "signatories.beneficiary.address": { | |
| label: "Adresse du candidat", | |
| hintText: "Si vous résidez en Auvergne Rhône Alpe, il est obligatoire de saisir votre adresse." | |
| id: beneficiarySectionIds.address, | |
| placeholder: "Ex : 10 Rue de la Paix, 75001 Paris", | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ce champ sera obligatoire à partir de la MEP de cette fonctionnalité (voir la date renseignée dans shouldValidateBeneficiaryAddressAndParse dans conventionRefinements.ts).
Après l'envoi de la convention par le bénéficiaire, l'adresse du candidat est visible dans :
la page de validation du conseiller :
le récapitulatif avant signature :
la convention au format pdf :
