Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CAV models #9897

Open
emthompson-usgs opened this issue Aug 8, 2024 · 4 comments
Open

New CAV models #9897

emthompson-usgs opened this issue Aug 8, 2024 · 4 comments

Comments

@emthompson-usgs
Copy link

Hi @mmpagani and @micheles,

@kslytherin and I are going to start working on a few new CAV models to contribute, specifically:

This issue's main purpose is to inform you about our plans and try to avoid duplicating effort, which happened for the Campbell and Bozorgnia model.

Also, the Liu and Macedo paper includes a conditional model, so I wanted to ask what the strategy for these models in OQ will be. If @g-weatherill's implementation in this PR has issues that prevent it from being merged, could we discuss how it needs to be modified to move things forward?

Thanks.

@emthompson-usgs
Copy link
Author

Also, I'll note that @kslytherin has an implementation of the Macedo et al. 2020 model that uses the ConditionalGMPE class by @g-weatherill. I'm pointing this out mostly to indicate that this is an important topic for us, and hopefully, OQ will also benefit from our contributions. If there are changes that are needed to the ConditionalGMPE class, we'll be happy to update the Macedo et al. 2020 implementation to reflect those changes.

@mmpagani
Copy link
Member

Hi @mmpagani and @micheles,

@kslytherin and I are going to start working on a few new CAV models to contribute, specifically:

This issue's main purpose is to inform you about our plans and try to avoid duplicating effort, which happened for the Campbell and Bozorgnia model.

Also, the Liu and Macedo paper includes a conditional model, so I wanted to ask what the strategy for these models in OQ will be. If @g-weatherill's implementation in this PR has issues that prevent it from being merged, could we discuss how it needs to be modified to move things forward?

Thanks.

Hi @emthompson-usgs,

Thanks for sharing info on models for CAV you aim to add in OQ. Hopefully, we will avoid the problems we faced while implementing CB's model. Regarding the conditional model implementation, I will send an example of implementation based on the modifiable GMPE. When are you planning to start working on the Liu and Macedo conditional part?

Thanks

@kslytherin
Copy link
Contributor

Hi @mmpagani,

@emthompson-usgs and I will start with the Bullock models first and then after we should get to the Liu and Macedo, but I would say it could take at least a few weeks until we get started on Liu and Macedo.

@mmpagani
Copy link
Member

mmpagani commented Aug 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants