Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the MagmaCoreService #169

Closed
twalmsley opened this issue Jan 22, 2024 · 0 comments · Fixed by #173
Closed

Improve the MagmaCoreService #169

twalmsley opened this issue Jan 22, 2024 · 0 comments · Fixed by #173
Assignees
@twalmsley

Comments

@twalmsley
Copy link
Collaborator

  • Try to make the methods more coherent.
  • Add manual transaction control.
  • Add javadoc to the class to explain when to use manual vs automatic transaction control.
  • Consider using a separate class to replace all the find* methods.
@twalmsley twalmsley self-assigned this Jan 22, 2024
@twalmsley twalmsley linked a pull request Jan 23, 2024 that will close this issue
169 Improve the MagmaCoreService API #173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twalmsley twalmsley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

169 Improve the MagmaCoreService API gchq/MagmaCore
1 participant
@twalmsley