Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): avoid dynamic metadata #38557

Closed

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Dec 4, 2023

#38110 was closed by mistake.

Companion to comply with frappe/frappe#23231

Depends on frappe/bench#1502

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 60.20%. Comparing base (7f8303a) to head (c1fa2e8).
Report is 460 commits behind head on develop.

❗ Current head c1fa2e8 differs from pull request most recent head 26532e9. Consider uploading reports for the commit 26532e9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38557      +/-   ##
===========================================
+ Coverage    60.15%   60.20%   +0.05%     
===========================================
  Files          757      759       +2     
  Lines        70719    69776     -943     
===========================================
- Hits         42542    42012     -530     
+ Misses       28177    27764     -413     
Files Coverage Δ
erpnext/__init__.py 69.13% <0.00%> (-0.87%) ⬇️

... and 105 files with indirect coverage changes

.releaserc Outdated Show resolved Hide resolved
Copy link

stale bot commented Jan 3, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 3, 2024
Copy link

stale bot commented Jan 25, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 25, 2024
Copy link

stale bot commented Feb 10, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Feb 10, 2024
@stale stale bot added the inactive label Feb 25, 2024
@frappe frappe deleted a comment from stale bot Feb 26, 2024
Copy link

stale bot commented Mar 12, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Mar 12, 2024
@stale stale bot closed this Mar 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
inactive needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants