Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check cache hash before using #1555

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

18alantom
Copy link
Member

Check hash md5 against previously calculated md5 (when setting cache), improve a few of the bench app-cache messages.

@18alantom
Copy link
Member Author

Ignoring SonarCloud cause it's complaining about MD5 not being safe and to use SHA512 instead.
This misses the context as MD5 is being used here for integrity check not security.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@ankush
Copy link
Member

ankush commented May 6, 2024

Ignoring SonarCloud cause it's complaining about MD5 not being safe and to use SHA512 instead.

Add usedforsecurity=False https://docs.python.org/3/library/hashlib.html

(maybe not, 3.9+ only 🥴 )

@18alantom 18alantom merged commit 4c38272 into develop May 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants