From e4e4559927cf1fdf47a4cd7f571f01e3c52b22c3 Mon Sep 17 00:00:00 2001 From: Ketan Umare Date: Mon, 9 Oct 2023 16:01:55 -0700 Subject: [PATCH] Adds Kevin's stales PR's PR 1: https://github.com/flyteorg/flytesnacks/pull/895 Signed-off-by: Ketan Umare --- .../data_types_and_io/data_types_and_io/custom_objects.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/data_types_and_io/data_types_and_io/custom_objects.py b/examples/data_types_and_io/data_types_and_io/custom_objects.py index 435ad65f1..78ccf4751 100644 --- a/examples/data_types_and_io/data_types_and_io/custom_objects.py +++ b/examples/data_types_and_io/data_types_and_io/custom_objects.py @@ -70,7 +70,9 @@ class Result: # %% [markdown] # :::{note} -# A data class supports the usage of data associated with Python types, data classes, FlyteFile, FlyteDirectory, and FlyteSchema. +# 1. A data class supports the usage of data associated with Python types, data classes, FlyteFile, FlyteDirectory, and FlyteSchema. +# 2. We use the Marshmallow package to serialize the dataclass, and it doesn't support Union Type in the dataclass. +# 3. Alternatively, you can use Mashumaro as the serialization engine, that is more performant and flexible. [TODO add example] # ::: # # Once declared, dataclasses can be returned as outputs or accepted as inputs.